Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offset index read integration #1779

Merged
merged 6 commits into from
Oct 7, 2024
Merged

offset index read integration #1779

merged 6 commits into from
Oct 7, 2024

Conversation

Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Oct 1, 2024 •
edited
Loading

Description of Changes

  1. Create IndexFile: a wrapper around IndexFileMut for exposing only read apis.
  2. Update Repo trait to get IndexFile
  3. Refactoring: Method naming changes to show clear distinction between read and write version of IndexFile
  4. Modify Commits iterator to lookup through Index for initial commit.

API and ABI breaking changes

N/A

Testing

image
Did some manual testing

@Shubham8287 Shubham8287 force-pushed the shub/commit-offset-intergation branch from 5fd6066 to 52b7779 Compare October 1, 2024 12:38
@Shubham8287 Shubham8287 force-pushed the shub/commit-offset-intergation branch from da37bb2 to a823fc6 Compare October 1, 2024 16:29
@Shubham8287 Shubham8287 force-pushed the shub/commit-offset-intergation branch from a823fc6 to fcf1af3 Compare October 1, 2024 17:27
@Shubham8287 Shubham8287 marked this pull request as draft October 1, 2024 19:42
@Shubham8287 Shubham8287 marked this pull request as ready for review October 3, 2024 12:29
@Shubham8287 Shubham8287 force-pushed the shub/commit-offset-intergation branch from 49e8d5c to eabbc35 Compare October 3, 2024 12:37
@Shubham8287 Shubham8287 requested a review from kim October 3, 2024 12:38
@Shubham8287 Shubham8287 force-pushed the shub/commit-offset-intergation branch from 4073214 to c4219d9 Compare October 4, 2024 09:25
kim
kim approved these changes Oct 4, 2024
View reviewed changes
crates/commitlog/src/segment.rs Outdated Show resolved Hide resolved
crates/commitlog/src/segment.rs Outdated Show resolved Hide resolved
crates/commitlog/src/segment.rs Outdated Show resolved Hide resolved
crates/commitlog/src/segment.rs Outdated Show resolved Hide resolved
crates/commitlog/src/commitlog.rs Outdated Show resolved Hide resolved
@Shubham8287 Shubham8287 added this pull request to the merge queue Oct 7, 2024
Merged via the queue into master with commit c5a9a0d Oct 7, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim kim kim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shubham8287 @kim