[analysis] Missing locals analysis of deftype args

[ericdallo]

version

2022.03.09

platform

JVM

editor

clojure-lsp

problem

there are missing locals analysis for bar in the following code:

(deftype Foo [bar] ;; missing analysis for bar
  Object
  (toString [_this]
    bar))

repro

clj -Sdeps '{:deps {clj-kondo/clj-kondo {:mvn/version "2022.03.09"}}}' -m clj-kondo.main --lint - --config '{:output {:analysis {:locals true} :format :json}}' <<< '(deftype Foo [bar] Object (toString [_this] bar))' | jq .analysis.local

Output

[
  {
    "end-row": 1,
    "scope-end-row": 1,
    "name": "_this",
    "scope-end-col": 49,
    "filename": "<stdin>",
    "str": "_this",
    "col": 38,
    "id": 3,
    "end-col": 43,
    "row": 1
  }
]

expected behavior

Expect bar to be available on locals

Note that bar local-usage is already available, missing only the locals one

[borkdude]

I found the issue: the bindings are analyzed, but are not "registered" so they won't be flagged as unused. But this has the negative side effect that they also don't end up in analysis. We clearly need to separate these concerns.

[ericdallo]

any reason to not flag them as unused like all other function arities?

[borkdude]

Yes, unused bindings must be renamed to be ignored: x -> _x. But renaming fields of a deftype or defrecord has the undesired effect that their APIs change.

[borkdude]

@ericdallo Fixed on master. Plz test :)

[ericdallo]

Thanks! Will test

[ericdallo]

Confimed this one fixed for clojure-lsp OOTB, thank you!