Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint toArray to fix JDK11 compatibility #37

Merged
merged 1 commit into from
Dec 6, 2018

Conversation

willcohen
Copy link
Contributor

On JDK11, toArray needs to be hinted (see openjdk change).

See CRRBV-18 for the core.rrb-vector fix, and CLJ-2374 for the same issue in clojure.

@willcohen
Copy link
Contributor Author

@amalloy re-noting this issue now that JDK 11 is released

@ghadishayban
Copy link

type hint can be ^objects in both places -- as it is upstream in Clojure.

Agreed that this needs a hotfix for JDK11.

@willcohen
Copy link
Contributor Author

PR is now modified to use ^objects

@danielsz
Copy link

danielsz commented Oct 7, 2018

Got bitten after upgrading to JDK11..

@magnars
Copy link

magnars commented Oct 10, 2018

Yes, for us it is the ring-middleware-format package that relies on circleci/clj-yaml which in turn uses flatland/ordered that fails when upgrading to JDK11. Any chance you could take a look at this, @amalloy?

@ghaskins
Copy link

+1 for this fix

@mikeThurmond
Copy link

mikeThurmond commented Dec 4, 2018

@amalloy I'm going to chime in here and hope that the owner/person with write access will merge this or create a hotfix for java11. Thanks!

@slipset slipset merged commit 16d0bc9 into clj-commons:develop Dec 6, 2018
@danielcompton
Copy link
Member

This is now available in [org.flatland/ordered "1.5.7"].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants