Improved test coverage #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add slingshot to api-test.clj dependencies
to test-query and test-query-all, to better reflect what they are really testing.
This better reflects what it is doing.
lread
reviewed
Sep 14, 2024
| (let [el (e/query *driver* {:class :foo} {:class :target})] | ||
| (is (= "target-2" (e/get-element-text-el *driver* el))))) | ||
| (testing "negative test cases" | ||
| ;; TODO: |
There was a problem hiding this comment.
Dave, this looks like an empty TODO
There was a problem hiding this comment.
Not empty, but still marking things that can be improved.
| (let [el (e/query *driver* [:enabled-disabled {:type :checkbox :fn/disabled false :fn/index 2}])] | ||
| (is (= "checkbox-3" (e/get-element-attr-el *driver* el "id")))))) | ||
| (testing "vector syntax" | ||
| ;; TODO: should check vectors with length 1, 2, and 3. |
There was a problem hiding this comment.
Dave I know this is a WIP with more changes to come, when you close up the WIP, please convert any remaining TODOs to git issues if you feel they are important.
There was a problem hiding this comment.
OK, I can do that. You want me to remove it with another commit to this PR, or just for the future. I'll be filling those in and removing TODOs as I fill them in.
There was a problem hiding this comment.
Yeah, just moving forward is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is filed against #640 but the issue should remain open as there are more tests and PRs coming.
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.