Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a more accurate exception when query vector is empty #664

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Sep 14, 2024

Closes #663

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address. Not yet.

  • This PR contains test(s) to protect against future regressions. Not currently, but these are coming in a larger PR dealing with test coverage.

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, @dgr, tx!

@lread lread merged commit ea9910e into clj-commons:master Sep 14, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-663-empty-query-vector branch September 14, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(query driver []) throws a misleading exception
2 participants