Make vector arg to fill-multi/fill-human-multi fill in order #652
Conversation
Previously, if the user supplied a vector argument to fill-multi or fill-human-multi, Etaoin would convert the vector to a map, then convert the map to a sequence of MapEntry pairs, and use those to fill multiple fields. Unfortunately, this threw away all the ordering information in the vector. This change processes the vector as a sequence of partitioned pairs and thereby keeps the order intact.
CHANGELOG.adoc
Outdated
| ** {issue}559[#559]: Deprecate use of `:active` with `query` and other APIs that use `query` under the hood. ({person}dgr[@dgr]) | ||
| ** {issue}642[#642]: Add `driver-type` to retrieve driver type keyword. ({person}dgr[@dgr]) | ||
| ** {issue}644[#644]: Deprecate `when-predicate` and `when-not-predicate` macros. See docstrings for guidance on alternatives. These will may be removed from the API at the next release that contains breaking changes. ({person}dgr[@dgr]) |
There was a problem hiding this comment.
Dave, are any of these strictly doc changes?
There was a problem hiding this comment.
Adding driver-type is not just a doc change. The others largely are (in the sense that adding ^:deprecated is a doc change.
There was a problem hiding this comment.
Let me go through and check each one carefully and submit a change set to the PR.
There was a problem hiding this comment.
OK, try that. I moved to the correct section and put them in numerical order.
There was a problem hiding this comment.
Sorry @dgr, I'm going to make you suffer one more time!
I think deprecating an fn is more than a doc change and, therefore, shouldn't be under doc changes. (If there are no doc changes left, feel free to delete the doc item in the list.)
Previously, if the user supplied a vector argument to fill-multi or fill-human-multi, Etaoin would convert the vector to a map, then convert the map to a sequence of MapEntry pairs, and use those to fill multiple fields. Unfortunately, this threw away all the ordering information in the vector. This change processes the vector as a sequence of partitioned pairs and thereby keeps the order intact.
Closes #649
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.