Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate when-predicate and when-not-predicate #645

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Deprecate when-predicate and when-not-predicate #645

merged 2 commits into from
Aug 23, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Aug 23, 2024 •
edited
Loading

Closes #644

  • Marks when-predicate and when-not-predicate as deprecated.
  • Leaves them in the namespace TOC for now.
  • Updates doc strings to suggest using when and when-not instead.
  • Updates CHANGELOG with note about the change.
  • Rewrites various other macros that previously used when-predicate and when-not-predicate to use when and when-not instead.

Please complete and include the following checklist:

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • This PR contains test(s) to protect against future regressions

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

lread
lread requested changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dgr!

You can go ahead and remove them from the TOC in the ns docstring.
This might discourage use.

@dgr
Copy link
Contributor Author

dgr commented Aug 23, 2024

Changes done.

lread
lread approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tx!

@lread lread merged commit e0ae5ab into clj-commons:master Aug 23, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-644-deprecate-when-predicate branch August 24, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lread lread lread approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate when-predicate and when-not-predicate macros
2 participants
@dgr @lread