Issue #559 #627
Merged
Issue #559 #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, get-active-element* was a private API. This simply changes the name to remove the "*" and makes it public.
Suggests to use get-active-element instead of (query driver :active).
lread
reviewed
Aug 17, 2024
|
Thanks @dgr! Lemme know what you think of my (minor) comments. See rewrite-clj for example of clj-kondo config to ignore deprecated vars internally. |
Test suite still calls child/children to detect regressions in these deprecated, but not yet removed, functions.
|
Looks great @dgr, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes described in the discussion of Issue #559.
It specifically:
query-fromandquery-all-from.childandchildren.get-active-elementa public API.:activeas a query parameter toqueryand updates doc strings and user guide to suggest the use ofget-active-elementinstead.Please complete and include the following checklist:
[x ] I have read CONTRIBUTING and the Etaoin Developer Guide.
[x ] This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
[x ] This PR contains test(s) to protect against future regressions
[x ] I have updated CHANGELOG.adoc with a description of the addressed issue.