ci: fix for safari #562
Merged
ci: fix for safari #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that GitHub Actions no longer supports `file:` urls for when using safaridriver. I spent some time trying to coax it to do so but safaridriver is not well documented, so instead of trying to come up with brittle incantations, now hitting a local http test server for api tests instead. Cookie tests were affected by this changed and adjusted/simplified: - browser specific tests consolidated (and edge now included) - turfed phantom test, we no longer support it Fixes #561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that GitHub Actions no longer supports
file:urls for when using safaridriver. I spent some time trying to coax it to do so but safaridriver is not well documented, so instead of trying to come up with brittle incantations, now hitting a local http test server for api tests instead.Cookie tests were affected by this changed and adjusted/simplified:
Fixes #561
Please complete and include the following checklist:
I have read CONTRIBUTING and the Etaoin Developer Guide.
This PR corresponds to an issue that the Etaoin maintainers have agreed to address.
This PR contains test(s) to protect against future regressions
I have updated CHANGELOG.adoc with a description of the addressed issue.