Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Driver defaults :path renamed to :path-driver #472

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

lread
Copy link
Collaborator

@lread lread commented Jul 1, 2022

Also:

  • no longer add nil driver map values
  • add defaults-global for defaults that apply to all driver types
  • add some more tests around created driver map
  • localized handling of most driver option defaults to one spot

Closes #471

Also:
- no longer add nil driver map values
- add `defaults-global` for defaults that apply to all driver types
- add some more tests around created driver map
- localized handling of most driver option defaults to one spot

Closes clj-commons#471
@lread lread requested review from borkdude and slipset as code owners July 1, 2022 16:41
@lread lread merged commit d75aef3 into clj-commons:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defaults options key does not match driver option key
1 participant