Add clj-kondo export config #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export config uses call hooks for better error reporting for users of our public API. Still using macro expand hooks for internal only macros. Using the brand spanking new `.clj_kondo` extension for hook source. This is nice to keep tooling less confused, but also keeps my brain less confused. Etaoin has a relatively large number of macros. I think I hit the important ones. But some macros are not under test and not verified by me as clj-kondo friendly. We'll add in support for any uncovered macros as needed. Ran a lint and turfed an unused var. Also added a sanity test for an etaoin.api2 macro. Added the lint task as a job to our CI build matrix. This helps to verify our clj-kondo config. Closes clj-commons#413
Forgot that CI does not have clojure cli installed!
Move them from ./clj-kondo` to` `./clj-kondo/hooks`.
This might arguably be a bit awkard for macroexpand hooks. But seems quite valuable to me for analyze call hooks.
It was a bit awkward. Clj-kondo, by design, suppresses warning from exported hooks. I could make it work but, in my opinion, the convolutions aren't worth the benefit. We'll just rely on editor lint integrations for the hooks which is a totally reasonable approach.
Moved local etaoin hooks under .clj-kondo/hooks so there is no longer and overlap with etaoin imported export hooks.
|
@borkdude, when you find a moment, I'd love to hear your feedback on this one. One thing I punted on a bit was throwing instead of registering findings. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export config uses call hooks for better error reporting for users of our
public API. Still using macro expand hooks for internal only macros.
Using the brand spanking new
.clj_kondoextension for hook source.This is nice to keep tooling less confused, but also keeps my brain less
confused.
Etaoin has a relatively large number of macros. I think I hit the
important ones. But some macros are not under test and not verified
by me as clj-kondo friendly. We'll add in support for any uncovered
macros as needed.
Ran a lint and turfed an unused var.
Also added a sanity test for an etaoin.api2 macro.
Added the lint task as a job to our CI build matrix.
This helps to verify our clj-kondo config.
Closes #413