road to bb: more babashka fs usage #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced direct JDK references with babashka fs abstractions. Of note: - turfed etaoin.util/with-tmp-dir and replaced its usages with babashka fs equivalent (Files/createTempDirectory is available in bb, I think). We've decided that etaoin.util is not part of our public API clj-commons#430, so not worried about deleting this macro. - some references to io/file replaced with fs/file for more flexible coercion. Contributes to clj-commons#380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced direct JDK references with babashka fs abstractions.
Of note:
fs equivalent (Files/createTempDirectory is unavailable in bb, I think).
We've decided that etaoin.util is not part of our public API docs: What is the supported public API? #430, so not
worried about deleting this macro.
Contributes to #380