road to bb: tweak process support #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proc was referencing java.lang.IllegalThreadStateException, an exception that babashka is currently unaware of. Good news is that the code that referenced this is entirely unused. Deleted it along with other unused vars. Also: - marked private vars as such - tweaked proc-test to help maybe diagnose flakyness on Windows on CI
|
LGTM |
Add a .waitFor after killing process. Move proc-tests out from under `testing` to their own `deftest`s. Have each test use its own port. And dump processes that are running in additon to chromedriver processes found. We'll remove these last bit after we achieve stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proc was referencing java.lang.IllegalThreadStateException, an exception
that babashka is currently unaware of.
Good news is that the code that referenced this is entirely unused.
Deleted it along with other unused vars.
Also:
Contributes to #380