Add new examples in getting started #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Showcasing `get-element-text`, `children`, `child`, `get-element-text-el` and some non-trivial querying for content.
|
Hiya @kidd, thanks, we'll take a look at this sometime! |
|
Thanks @kidd, I had a look and like it! At first I was a little worried that Wikipedia HTML might have since changed, but I guess it is pretty static! The doc structure has changed, and it has been over a year since you contributed this, so I'll handle the merge conflicts. Please don't be offended if I make some minor changes. Thanks for your contribution! |
* master: (94 commits) Switch with-exception from private to no-doc (clj-commons#457) API review: docstrings, arglists, publics (clj-commons#456) User guide and usage related updates (clj-commons#454) docs: changelog [skip ci] docs: README: update contributors [skip ci] Add note about new tabs/windows to Troubleshooting (clj-commons#452) [skip ci] Review and update Dockerfile (clj-commons#451) lint: tweak .gitignore [skip ci] lint: abandon idea of linting clj-kondo hooks lint: lint clj-kondo hooks code too lint: update dev guide lint: distinguish internal hooks from imports lint: bump clj-kondo lint: Use bb's (clojure) instead of shelling out Add clj-kondo export config Update: cheshire 5.11.0 was just released Bump dependencies to current releases docs: update changelog [skip ci] docs: add Dave Yarwood to contributors [skip ci] Move `effectively-displayed?` docstring to the public `displayed-el?` function ...
lread
added a commit
to verma/etaoin
that referenced
this pull request
Jun 16, 2022
Ya I see it: - running? and wait-running very likely don't mean much for for a remote hosted WebDriver service as they only check the host and port for reachability. We could extract host and port from a the webdriver-url but checking that we can open a socket on port 443 for chrome.browserless.io doesn't say much about WebDriver service running at https://chrome.browserless.io/webdriver. Minor changes: - documented in user guide - added a test - minor strategy change around wait-running - check :webdriver-url for nil rather than via str/blank? (for consistency with other options) * master: (97 commits) docs: changelog [skip ci] Add new examples in getting started (clj-commons#364) Switch with-exception from private to no-doc (clj-commons#457) API review: docstrings, arglists, publics (clj-commons#456) User guide and usage related updates (clj-commons#454) docs: changelog [skip ci] docs: README: update contributors [skip ci] Add note about new tabs/windows to Troubleshooting (clj-commons#452) [skip ci] Review and update Dockerfile (clj-commons#451) lint: tweak .gitignore [skip ci] lint: abandon idea of linting clj-kondo hooks lint: lint clj-kondo hooks code too lint: update dev guide lint: distinguish internal hooks from imports lint: bump clj-kondo lint: Use bb's (clojure) instead of shelling out Add clj-kondo export config Update: cheshire 5.11.0 was just released Bump dependencies to current releases docs: update changelog [skip ci] ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this project! Seems super useful!
I added a couple of use cases and function usages that were not shown in the readme.
Also, an important use case to me was to do a bit more sophisticated querying. I added the examples in the readme:
If there's a smarter way to accomplish that, I'm happy to change it if you show me the way :)
Showcasing
get-element-text,children,child,get-element-text-eland some non-trivial querying for content.