add macro with-screenshots #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrishaev
reviewed
Oct 8, 2020
src/etaoin/api.clj
Outdated
| @@ -2972,6 +2972,18 @@ | |||
| (b64-to-file b64str file) | |||
| (util/error "Empty screenshot, query: %s" q)))) | |||
|
|
|||
| (defmacro with-screenshots | |||
| "Make screenshot after each form" | |||
| [driver folder & body] | |||
There was a problem hiding this comment.
Хорошо, несколько моментов
- переименовать folder в directory, потому что первое скорее принято в винде.
- синтаксис
make-screenshot-fileзапутан, лучше записать ее через обычную(fn []).
igrishaev
reviewed
Oct 8, 2020
src/etaoin/api.clj
Outdated
| (defmacro with-screenshots | ||
| "Makes a screenshot after each form" | ||
| [driver dir & body] | ||
| (let [make-screenshot-file# (fn [dir] |
There was a problem hiding this comment.
Лучше назвать функцию make-file-path, потому что она не создает файл на диске, а только строит путь. Второй момент -- можно убрать входящий параметр, потому что все равно функция замкнута на dir.
There was a problem hiding this comment.
И еще -- можно добавить в имя файла тип драйвера, например chrome-11112222333.png
There was a problem hiding this comment.
И добавить в readme пример в секцию о скриншотах.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#fixies #44