add docs for ide #342
Merged
add docs for ide #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrishaev
reviewed
Oct 8, 2020
README.md
Outdated
| ``` clojure | ||
| (def driver (chrome)) | ||
| (def ide-file (io/resources "ide/test.side"')) | ||
| (def base-url (-> "html/test.html" io/resources str)) |
There was a problem hiding this comment.
какое-то время не мог понять эту строку. Это чтобы получить урл типа file://..../html.test? И еще момент: в io/resources на конце лишняя s
There was a problem hiding this comment.
да, это пример из наших тестов локальных, мб просто гугол написать?)
igrishaev
reviewed
Oct 8, 2020
README.md
Outdated
|
|
||
| ``` clojure | ||
| (def driver (chrome)) | ||
| (def ide-file (io/resources "ide/test.side"')) |
There was a problem hiding this comment.
Здесь лишняя s на конце resources и лишняя одинарная кавычка
igrishaev
reviewed
Oct 8, 2020
README.md
Outdated
| (def ide-file (io/resources "ide/test.side"')) | ||
| (def base-url (-> "html/test.html" io/resources str)) | ||
|
|
||
| (ide/run-ide-script driver ide-file {:base-url base-url :test-name "test-asserts"}) |
There was a problem hiding this comment.
Можно добавить, что base-url нужен, чтобы переопределить базовый урл из файла. Например, файл был записан на локальной машине (http://localhost:8080), а мы хотим выполнить на стейджинге (https://preprod-001.company.com)
И добавить здесь список опций, которые могут быть в options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#336