add logging to files #257
Merged
add logging to files #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrishaev
reviewed
Jul 31, 2020
src/etaoin/api.clj
Outdated
| @@ -2894,6 +2894,7 @@ | |||
| proxy | |||
| profile | |||
| headless | |||
| log-files | |||
There was a problem hiding this comment.
тут не очень, что файлы слиплись в одну мапу. Лучше отдельными ключами log-stdout и log-stderr
igrishaev
reviewed
Jul 31, 2020
src/etaoin/api.clj
Outdated
| @@ -2939,7 +2940,7 @@ | |||
|
|
|||
| proc-args (drv/get-args @driver) | |||
| _ (log/debugf "Starting process: %s" (str/join \space proc-args)) | |||
| process (proc/run proc-args)] | |||
| process (proc/run proc-args log-files)] | |||
There was a problem hiding this comment.
тут их нужно будет передать мапой, вроде
{:log-stdout log-stdout
:log-stderr log-stderr}
igrishaev
reviewed
Jul 31, 2020
src/etaoin/proc.clj
Outdated
|
|
||
| (defn get-null-file ^java.io.File | ||
| [] | ||
| (if-let [windows? (str/starts-with? (System/getProperty "os.name") "Windows")] |
There was a problem hiding this comment.
тут переменная windows? не нужна, поэтому просто if. Но еще лучше вынести ее на уровне def, потому что операционка не меняется в рантайме.
(def windows? ...)
(if windows?
...
...)
igrishaev
reviewed
Jul 31, 2020
src/etaoin/proc.clj
Outdated
|
|
||
| (defn get-log-file | ||
| [file-path] | ||
| (if file-path (io/file file-path) |
There was a problem hiding this comment.
положительную ветку перенести на след. строку после условия
igrishaev
reviewed
Jul 31, 2020
README.md
Outdated
| @@ -986,6 +986,10 @@ skipped or have nil values. Some of them, if not passed, are taken from the | |||
| ;; :err (aliases :error, :severe, :crit, :critical), :all. When not passed, | |||
| ;; :all is set. | |||
| :log-level :err ;; to show only errors but not debug | |||
|
|
|||
| ;; Paths to log files | |||
There was a problem hiding this comment.
тут бы уточнить, что к логам именно вебдрайвера, а то не понятно
;; Paths to the driver's log files as strings.
;; When not set, the output goes to /dev/null (or NULL on Windows)
:log-stdout "/path/to/stdout.log"
:log-stderr "/path/to/stderr.log"
igrishaev
reviewed
Jul 31, 2020
src/etaoin/proc.clj
Outdated
| (:import java.lang.IllegalThreadStateException | ||
| java.io.IOException)) | ||
|
|
||
| (def windows? (str/starts-with? (System/getProperty "os.name") "Windows")) |
There was a problem hiding this comment.
тут двойной пробел после with?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#fixies #125