Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always include WebDriver process liveness in http client exception #469

Closed
lread opened this issue Jun 30, 2022 · 0 comments · Fixed by #475
Closed

Always include WebDriver process liveness in http client exception #469

lread opened this issue Jun 30, 2022 · 0 comments · Fixed by #475

Comments

@lread
Copy link
Collaborator

lread commented Jun 30, 2022 •
edited
Loading

Currently

We use slingshot to throw+ on HTTP exceptions.
This map we throw includes the :driver which includes the WebDriver :process.

While poking around #464 and #465 I found I wanted to also report if the WebDriver process is running and if not, its exit code.

Proposal

Adjust our http client to slingshot throw+ also on unexpected exceptions (ex. timeouts).
Include unexpected exception as cause.

When :driver includes :process check if it is alive.
If not then realize its exit code and include it under and updated :process.
@lread lread changed the title Always log WebDriver process liveness on http exception Always log WebDriver process liveness on http client exception Jun 30, 2022
@lread lread changed the title Always log WebDriver process liveness on http client exception Always include WebDriver process liveness on http client exception Jun 30, 2022
lread added a commit to lread/etaoin that referenced this issue Jul 4, 2022
@lread
Include driver process liveness in some exceptions
5b63645 
When an http request, for example, times out one might wonder if the
WebDriver process is still running.

We now use slingshot throw+ as we do for http status errors. This throw+
still includes the :driver :process but checks if it is alive and
realizes its exit value in the thrown map if dead.

Also: if an exception occurs when booting a driver, any launched WebDriver
process is now cleaned up.

Also: reworked some proc tests to always attempt cleanup even when
exceptions occur.

Closes clj-commons#469
@lread lread changed the title Always include WebDriver process liveness on http client exception Always include WebDriver process liveness in http client exception Jul 4, 2022
@lread lread mentioned this issue Jul 4, 2022
Merged
@lread lread closed this as completed in #475 Jul 4, 2022
lread added a commit that referenced this issue Jul 4, 2022
@lread
Include driver process liveness in some exceptions (#475)
92fbca2 
When an http request, for example, times out one might wonder if the
WebDriver process is still running.

We now use slingshot throw+ as we do for http status errors. This throw+
still includes the :driver :process but checks if it is alive and
realizes its exit value in the thrown map if dead.

Also: if an exception occurs when booting a driver, any launched WebDriver
process is now cleaned up.

Also: reworked some proc tests to always attempt cleanup even when
exceptions occur.

Closes #469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include driver process liveness in some exceptions lread/etaoin
1 participant
@lread