Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Default override for safaridriver location is perhaps stale #384

Closed
lread opened this issue May 10, 2022 · 0 comments · Fixed by #401
Closed

tests: Default override for safaridriver location is perhaps stale #384

lread opened this issue May 10, 2022 · 0 comments · Fixed by #401

Comments

@lread
Copy link
Collaborator

lread commented May 10, 2022

By default, tests set the location of safaridriver to:

"/Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver"

This must have made sense at one point, but now we can just find safaridriver on the PATH and don't need this override.

I shall follow p with a PR
lread added a commit to lread/etaoin that referenced this issue May 13, 2022
@lread
Look for safaridrver on PATH by default
31ebafe 
Closes clj-commons#384
@lread lread mentioned this issue May 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Look for safaridrver on PATH by default lread/etaoin
1 participant
@lread