Skip to content

Commit

Permalink
Address JDK 19 Thread/sleep Clojure interop (#504)
Browse files Browse the repository at this point in the history
* Address JDK 19 Thread/sleep Clojure interop

JDK 19's Thread/sleep now also accepts a Duration.
Add a ^long type hint to remove this new ambiguity for Clojure interop.

Closes #503

* docs: update change log
  • Loading branch information
lread authored Nov 30, 2022
1 parent 1174775 commit cdda5e4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ A release with an intentional breaking changes is marked with:
== Unreleased

* https://github.com/clj-commons/etaoin/issues/503[#503]: Address Clojure interop issue introduced by new Thread/sleep signature in JDK 19

== v1.0.38 [minor breaking]

Minor Breaking Changes
Expand Down
2 changes: 1 addition & 1 deletion src/etaoin/api.clj
Original file line number Diff line number Diff line change
Expand Up @@ -2453,7 +2453,7 @@
(#_{:clj-kondo/ignore [:unused-binding]} [driver seconds]
(wait seconds))
([seconds]
(Thread/sleep (* seconds 1000))))
(Thread/sleep ^long (* seconds 1000))))

(defmacro with-wait
"Execute `body` waiting `seconds` before each form.
Expand Down

0 comments on commit cdda5e4

Please sign in to comment.