Netatmo oh3 update #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
…her station discovery Signed-off-by: clinique <[email protected]>
Trying to spot wrong/redundant updates of persons/cameras Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
Signed-off-by: clinique <[email protected]>
clinique
requested changes
May 11, 2021
| @@ -35,6 +35,8 @@ | |||
| private List<NAHomeEvent> events = List.of(); | |||
| private List<NAThermProgram> thermSchedules = List.of(); | |||
| private List<NAWelcome> cameras = List.of(); | |||
|
|
|||
| private @Nullable NAObjectMap<NARoom> rooms; | |||
There was a problem hiding this comment.
I would prefer having this non null with an empty list like the other above
...enhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/NAHome.java
Show resolved
Hide resolved
| return rooms; | ||
| } | ||
| public @Nullable NARoom getRoom(String key) { | ||
| return rooms.get(key); |
There was a problem hiding this comment.
Subject to NPE if rooms is null
...binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/NAHomeStatus.java
Show resolved
Hide resolved
...enhab.binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/NARoom.java
Show resolved
Hide resolved
....binding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/energy/Home.java
Show resolved
Hide resolved
...ng.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/energy/Homestatus.java
Show resolved
Hide resolved
...ng.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/energy/Homestatus.java
Show resolved
Hide resolved
...inding.netatmo/src/main/java/org/openhab/binding/netatmo/internal/api/dto/energy/Module.java
Show resolved
Hide resolved
clinique
force-pushed
the
Netatmo_OH3_update
branch
from
b5d6129 to
3296833
Compare
clinique
added a commit
that referenced
this pull request
Nov 1, 2024
Signed-off-by: Gaël L'hopital <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.