Added option for ice on lakes. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me - @SMoorthi-emc, do you agree? |
| @@ -109,6 +112,14 @@ subroutine GFS_radiation_surface_run ( & | |||
| ! Intialize intent(out) variables | |||
| sfcalb = 0.0 | |||
|
|
|||
There was a problem hiding this comment.
This is good. However, I can't see the full code here. Is fraco open water fraction? If so, fracl+fraco+fraci=1 right?
There was a problem hiding this comment.
Thanks for checking. You are correct, fracl+fraco+fraci=1 for the fractional mask case. Not that in the git diff view, you can expand the sections that are hidden by clicking on the arrows in the blue boxes between the line numbers on the left. I'll merge this into my branch/PR.
SMoorthi-emc
approved these changes
May 13, 2021
climbfuji
approved these changes
May 14, 2021
climbfuji
merged commit c31b1ba
into
climbfuji:move_sfc_emis_alb_calculation_to_its_own_scheme_and_z0_composite_consistent
climbfuji
pushed a commit
that referenced
this pull request
Dec 2, 2021
remove some false values over the glacial ice
climbfuji
pushed a commit
that referenced
this pull request
Nov 7, 2022
NCAR/main PR NCAR#967 (Bugfix and optimization of prognostic closure for the P8 physics suit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the check if there is a fraction of ice in the grid cell, the min_seaice threshold is used for sea ice and min_lakeice is used for lake ice.