-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/pla 331 lift input directory creation into distinct step #106
Feature/pla 331 lift input directory creation into distinct step #106
Conversation
I tried to update the integration tests here but seems they are already broken ¯_(ツ)_/¯ |
@olaughter: I had temporarily broken them by removing some 2 year old secrets. It's fixed now! |
Aha okay! Rerunning 👍 |
Nope still busted |
Ah sorry, I was thinking of the |
Ah no worries. The pipeline repo tests do actually cover the interface here, so I'm inclined to ignore the broken test... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's nice that it just needs the presence, and thus is easily changed. I've got just an open, non-blocking question.
Replace execution data with db_state file. We already pass this in to the pipeline, like so:
Meaning we can use this to skip the execution data when looking for the updates file.