Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 bug fix in local vespa schema (summary features) #427

Merged

Conversation

olaughter
Copy link
Contributor

@olaughter olaughter commented Dec 5, 2024

Description

Update to Vespa schema to fix showing rank features. This is already deployed on prod Vespa – this just updates the schema of the local test instance

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@olaughter olaughter requested a review from a team as a code owner December 5, 2024 16:33
Copy link

linear bot commented Dec 5, 2024

@kdutia kdutia changed the title 🤖 Update vespa test files 🤖 change match-features to summary-features in the staging vespa schemas Dec 5, 2024
@kdutia kdutia requested a review from a team as a code owner December 9, 2024 09:29
@kdutia kdutia changed the title 🤖 change match-features to summary-features in the staging vespa schemas 🤖 bug fix in local vespa schema (summary features) Dec 16, 2024
@kdutia kdutia merged commit 870fb8f into main Dec 16, 2024
2 checks passed
@kdutia kdutia deleted the vespa-test-update-feature/sci-140-implement-summary-features branch December 16, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants