Fix logic for event dates in raw SQL #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make pipeline query support multi geos * Make ordering of db objects the same * Update comment * Make sure query is more equivalent to incumbent * Create db_state_validator.py * Create way of validating two db state files * Revert "Create db_state_validator.py" This reverts commit a03f693. * Get most recent slug comments * Break formatting of db_state contents into separate function * Refactor generating db_state content into new function * Updating the script to use sdk models. (#389) Co-authored-by: Mark <[email protected]> * Add test cases for checking db_state content * Refactor write_documents_to_s3 for test isolation --------- Co-authored-by: NextGenEng <[email protected]> Co-authored-by: Mark <[email protected]>
katybaulch
deleted the
feature/pdct-1440-implement-mulit-geographies-in-the-navigator-backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix event date logic in download and pipeline queries and explicitly infer from ISO format.
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR,MINOR, andPATCHversions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]with no spaces in between thebrackets and the
xType of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist