Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in local full stack deployment changes. #385

Conversation

THOR300
Copy link
Contributor

@THOR300 THOR300 commented Oct 14, 2024

Description

This pull request is a bug fix for a failing local deployment of the frontend and backend.

  • Change the vespa url that the backend uses. Port 19071 is the config endpoint whereas 8080 is the content endpoint, see the documentation here.

The port 8080 is published to make the search and feed interfaces accessible from outside the docker container, 19071 is the config server endpoint. Only one docker container named vespa can run at a time so change the name if needed. See Docker containers for more insights.

  • Creates a local certificates directory with empty cert and key. The vespa code just expects us to be passing these in or an api key.
  • Adds documentation and some initial draft code for spinning up ones local environment to test the frontend and backend stack. This includes details of dumping and loading data from vespa.

Note: We're not actually passing in the vespa url from the .env into the docker-compose is there a reason for this, do we want to change this?

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@THOR300 THOR300 marked this pull request as ready for review October 14, 2024 09:35
@THOR300 THOR300 requested a review from a team as a code owner October 14, 2024 09:35
@THOR300 THOR300 requested a review from katybaulch October 14, 2024 09:37
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing ⭐ ⭐

@THOR300 THOR300 merged commit cf935f4 into main Oct 14, 2024
12 checks passed
@THOR300 THOR300 deleted the feature/pla-219-test-concept-filtering-locally-using-local-vespa-instance-v4 branch October 14, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants