Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pdct 1559 download all data should only show data from allowed corpora #371

Conversation

katybaulch
Copy link
Contributor

Description

  • Restrict download this search data to only data in allowed corpora
  • Restrict download all data to only data in allowed corpora
  • Always exclude MCF from download
  • Add test coverage for this search and whole data download
  • Refactor app token factory into class
  • Update existing vespa search tests
  • Use LRU cache for whole database download query

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested review from a team as code owners October 8, 2024 18:34
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ... general comment for post-COP (you probably know this) the routers are getting far too much code in at the moment.

@katybaulch katybaulch merged commit 299cfab into main Oct 9, 2024
12 checks passed
@katybaulch katybaulch deleted the feature/pdct-1559-searchesdownload-all-data-should-only-show-document-if branch October 9, 2024 08:39
@katybaulch
Copy link
Contributor Author

Yeah totally agree with you. Will raise now :)

lgtm ... general comment for post-COP (you probably know this) the routers are getting far too much code in at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants