Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the test data to include concepts. #360

Closed
wants to merge 10 commits into from

Conversation

THOR300
Copy link
Contributor

@THOR300 THOR300 commented Sep 30, 2024

Description

  • Updates the test data for the vespa application to contain concepts. This is to validate that we can ingest the relevant data.

Temporarily against main to trigger tests.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@THOR300 THOR300 changed the base branch from vespa-test-update-feature/cpr-317-update-schema-in-vespa-to-accommodate-concepts-test-data to main September 30, 2024 08:51
@THOR300 THOR300 marked this pull request as ready for review October 7, 2024 14:01
@THOR300 THOR300 requested review from a team as code owners October 7, 2024 14:01
@THOR300
Copy link
Contributor Author

THOR300 commented Oct 7, 2024

TODO: Add the commit hashes of the test files that were indented only (where formatting is the only change) to the git blame ignore file.

@THOR300
Copy link
Contributor Author

THOR300 commented Oct 8, 2024

TODO: Add the commit hashes of the test files that were indented only (where formatting is the only change) to the git blame ignore file.

Merged on this PR approved by Katy with a nicer commit history to add the test file indentation update to a git blame ignore.

@THOR300 THOR300 closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants