Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to Python 3.10 #324

Merged

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Sep 6, 2024

Description

As part of upgrading all our systems.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • DB_CLIENT DEPENDENCY IS ON THE LATEST VERSION
  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@jesse-c jesse-c requested a review from a team as a code owner September 6, 2024 15:17
Copy link

linear bot commented Sep 6, 2024

@jesse-c jesse-c force-pushed the feature/pla-154-migrate-navigator-backend-to-python-310 branch from 3fd4112 to d888744 Compare September 9, 2024 08:56
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Have you checked the Python version in the trunk.yaml file to make sure that is also 3.10.x (as trunk config is version controlled for this repo)?

@jesse-c
Copy link
Contributor Author

jesse-c commented Sep 9, 2024

@katybaulch: I hadn't explicitly! I just did now, and it's already on 3.10.x [1]. I've done a grep for python.*3\.9 and there's no results now.

[1]

@jesse-c jesse-c force-pushed the feature/pla-154-migrate-navigator-backend-to-python-310 branch 6 times, most recently from 3d1121a to 64ebf03 Compare September 9, 2024 12:49
As part of upgrading all our systems.
@jesse-c jesse-c force-pushed the feature/pla-154-migrate-navigator-backend-to-python-310 branch from 64ebf03 to f2127ab Compare September 9, 2024 12:51
@katybaulch
Copy link
Contributor

@katybaulch: I hadn't explicitly! I just did now, and it's already on 3.10.x [1]. I've done a grep for python.*3\.9 and there's no results now.

[1]

Eyyy nice one, go for the merge!

@jesse-c jesse-c merged commit 796690e into main Sep 9, 2024
12 checks passed
@jesse-c jesse-c deleted the feature/pla-154-migrate-navigator-backend-to-python-310 branch September 9, 2024 13:14
jesse-c added a commit that referenced this pull request Sep 9, 2024
@jesse-c jesse-c mentioned this pull request Sep 9, 2024
18 tasks
jesse-c added a commit that referenced this pull request Sep 10, 2024
jesse-c added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants