Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dal to cpr_sdk. #260

Merged

Conversation

THOR300
Copy link
Contributor

@THOR300 THOR300 commented Apr 8, 2024

Description

  • This change involves updating the dependency that is specified for the data access library to the cpr sdk.
  • This effectively utilises a pypi package as opposed to a public github repo.

Proposed version

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Type of change

I don't know if this fits with any of these but adding breaking change as this is inline with the version bump.

  • Bug fix
  • New feature
  • Breaking change
  • GitHub workflow update
  • Documentation update
  • Refactor legacy code
  • Dependency update

How Has This Been Tested?

  • Existing unit and integration tests.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

Copy link

linear bot commented Apr 8, 2024

tests/core/test_search.py Outdated Show resolved Hide resolved
@THOR300 THOR300 marked this pull request as ready for review April 9, 2024 12:26
@THOR300 THOR300 requested a review from a team as a code owner April 9, 2024 12:26
@THOR300 THOR300 requested a review from katybaulch April 9, 2024 12:26
tests/core/test_search.py Outdated Show resolved Hide resolved
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a code suggestion

tests/core/test_search.py Outdated Show resolved Hide resolved
@THOR300 THOR300 requested a review from diversemix April 9, 2024 14:43
Copy link
Contributor

@katybaulch katybaulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!! And lovely driveby fixes for pyright, thanks 🦖

@THOR300 THOR300 dismissed diversemix’s stale review April 9, 2024 15:29

Discussion via slack!

@THOR300 THOR300 merged commit 6fa855c into main Apr 9, 2024
12 checks passed
@THOR300 THOR300 deleted the feature/rnd-1185-update-navigator-backend-to-use-the-cpr_sdk branch April 9, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants