-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating dal to cpr_sdk. #260
Merged
THOR300
merged 18 commits into
main
from
feature/rnd-1185-update-navigator-backend-to-use-the-cpr_sdk
Apr 9, 2024
Merged
Updating dal to cpr_sdk. #260
THOR300
merged 18 commits into
main
from
feature/rnd-1185-update-navigator-backend-to-use-the-cpr_sdk
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-use-the-cpr_sdk Merge commit.
THOR300
commented
Apr 9, 2024
diversemix
previously requested changes
Apr 9, 2024
diversemix
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a code suggestion
…to CprSdkFilters model.
katybaulch
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!! And lovely driveby fixes for pyright, thanks 🦖
THOR300
deleted the
feature/rnd-1185-update-navigator-backend-to-use-the-cpr_sdk
branch
April 9, 2024 15:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Proposed version
Type of change
I don't know if this fits with any of these but adding breaking change as this is inline with the version bump.
How Has This Been Tested?
Reviewer Checklist