Feature/pdct 774 remove csvs from backends pipeline trigger #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use the csv ingest process so don't need to waste test time on it
This had a bunch of overhang from before the admin service. Turning it into a dedicated trigger makes it easier to call and run
Some of these paths are still used by other code. Leaving them in for now is the path of least resistance for getting this done and gets closer to a tidier state. With any luck we'll be able to take it further next time
Unfortunatly we rely on the ingest code for test setup. So although this has been removed from the app, we still need it to maintain test coverage. That being said, we are one step closer to deleting it and no longer need to test it, so this is still progress. The ideal solution here probably to replace the many fragmented test setup with a single, repurposable setup factory. But thats beyond the scope of the current change
These are no longer needed following the previous commit
diversemix
reviewed
Jan 31, 2024
diversemix
reviewed
Jan 31, 2024
diversemix
approved these changes
Jan 31, 2024
Good shout, changing now in case we never get to round two of cleanup 😅 |
olaughter
force-pushed
the
feature/pdct-774-remove-csv-validation-from-backends-pipeline-trigger
branch
from
278b731 to
b6c29c2
Compare
olaughter
deleted the
feature/pdct-774-remove-csv-validation-from-backends-pipeline-trigger
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to the admin service we no longer need to pass csv's into the pipeline trigger endpoint. This means a whole swathe of code is no longer used. Unpicking this means we can simplify the trigger and no longer run some unnecessary and cumbersome tests (A minute and a half! Which is half the unit tests!).
Unfortunately, pulling on the code-deletion thread revealed a place the old ingest code was in fact still used in two places:
The test setup one presents a problem. But also points to a wider issue beyond the scope of this humble change, that we have multiple different test setup functionalities across our test suite. For now, I have simply moved the ingest code into tests (Which will make it easier to clean up and means we can still turn off the tests for it). I've also added a task to our linear board to consolidate all our test setup strategies (and move away from inline csv data fixtures 🙀) so that this can be flollowed up on in the future
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist