Fix keyword filter handling #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously a bug fix attempted to resolve the fact that postgres and vespa use different titles for fields. However it has led to keyword_filters being preprocessed more than once for vespa and not at all for browse.
olaughter
requested review from
diversemix,
PatFawbertMills,
katybaulch and
THOR300
diversemix
approved these changes
Jan 23, 2024
Following additional browse preprocessing that brings this up a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously a bug fix attempted to resolve the fact that postgres and
vespa use different titles for fields. However it has led to keyword_filters
being preprocessed more than once for vespa and not at all for browse.
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist