Pages Bug fix attempt no.2. #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diversemix
reviewed
Dec 4, 2023
| @@ -76,7 +76,7 @@ def _search_request( | |||
| data_access_search_response, | |||
| limit=search_body.limit, | |||
| offset=search_body.offset, | |||
| ) | |||
| ).increment_pages() | |||
There was a problem hiding this comment.
I would argue that calling process_vespa_search_reposonse should also handle the page numbering. We are in a router here and this should not contain any search response logic. Having said that there are functions that exist at the bottom of the file with vespa logic in 😢 - probably a tech debt ticket
There was a problem hiding this comment.
Yes very open to that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addition of a method to the SearchResponse class to increment that pages on the document passage matches.
Type of change
How Has This Been Tested?
Unit tests that assert the method works correctly.
Reviewer Checklist