Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support supplied cert/key pair supplied as env vars #177

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

joel-wright
Copy link

@joel-wright joel-wright commented Nov 1, 2023

Description

Adds support for serialising vespa key/cert files to disk at startup supplied as base64 encoded env vars.

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Ad-hoc startup tests

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

startup.sh Show resolved Hide resolved
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joel-wright joel-wright force-pushed the feature/vespa-keys-at-deploy branch from e3ff662 to fcf65b3 Compare November 1, 2023 18:52
@joel-wright joel-wright merged commit 0af88ff into main Nov 1, 2023
2 checks passed
@joel-wright joel-wright deleted the feature/vespa-keys-at-deploy branch November 1, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants