Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for vespa search #174

Merged
merged 8 commits into from
Nov 1, 2023
Merged

Conversation

joel-wright
Copy link

Description

Support for optionally using a configured vespa instance for search.

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

New tests added & test vespa instance added to docker compose environment.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@joel-wright joel-wright force-pushed the feature/optional-vespa-search branch from f8c2b7b to a7bbb5d Compare October 25, 2023 19:30
@joel-wright joel-wright force-pushed the feature/optional-vespa-search branch from a7bbb5d to 91d4aeb Compare October 25, 2023 22:18
@joel-wright joel-wright force-pushed the feature/optional-vespa-search branch from da0fb59 to 516f0b5 Compare October 26, 2023 16:26
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far - is it meant to be still draft?

@joel-wright joel-wright changed the title WIP: initial support for vespa search Initial support for vespa search Oct 31, 2023
@joel-wright joel-wright marked this pull request as ready for review October 31, 2023 17:19
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look good - we perhaps need to chat about cpr_data_access and the models contained therein. Just to fully understand what the intention is and the future of this is.

@joel-wright joel-wright merged commit f5cf19e into main Nov 1, 2023
2 checks passed
@joel-wright joel-wright deleted the feature/optional-vespa-search branch November 1, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants