Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add family slug to db-state file generated to trigger pipeline #170

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Add family slug to db-state file generated to trigger pipeline #170

merged 1 commit into from
Oct 10, 2023

Conversation

joel-wright
Copy link

For Vespa indexing, add family slug to db-state so it does not need to be calculated later by the backend.

Description

Please include:

  • a summary of the changes
  • links to any related issue/ticket
  • any additional relevant motivation and context
  • details of any dependency updates that are required for this change

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Existing tests modified to validate new data

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@joel-wright joel-wright requested a review from diversemix October 9, 2023 15:04
@joel-wright joel-wright marked this pull request as ready for review October 9, 2023 15:04
diversemix
diversemix approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joel-wright joel-wright merged commit 3935aec into main Oct 10, 2023
2 checks passed
@joel-wright joel-wright deleted the feature/add-family-slug-to-db-state branch October 10, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diversemix diversemix diversemix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joel-wright @diversemix