Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db_state output to include metadata & remove corpus specificity #164

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

joel-wright
Copy link

Description

Update db_state file to include metadata & family_id. Make db_state file smoothly support both CCLW & UNFCCC data whilst sending more information to the pipeline.

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Existing tests extended/modified.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@joel-wright joel-wright requested a review from diversemix August 14, 2023 16:51
@joel-wright joel-wright marked this pull request as ready for review August 14, 2023 17:00
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@joel-wright joel-wright merged commit 44c6cf3 into main Aug 15, 2023
@joel-wright joel-wright deleted the feature/generic-db-state branch August 15, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants