Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to TaxonomyEntry type & initial data loading #138

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

joel-wright
Copy link

Description

Really minor fix to TaxonomyEntry typing & initial data loading to allow make start without errors.

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Existing tests sufficient

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@joel-wright joel-wright requested a review from THOR300 June 12, 2023 13:46
Copy link
Contributor

@THOR300 THOR300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joel-wright joel-wright merged commit b97de0b into main Jun 12, 2023
@joel-wright joel-wright deleted the fix/minor-taxonomy-pydantic-fix branch June 12, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants