Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author to UNFCCC metadata #129

Merged
merged 1 commit into from
May 31, 2023
Merged

Add author to UNFCCC metadata #129

merged 1 commit into from
May 31, 2023

Conversation

joel-wright
Copy link

Description

Adds author to UNFCCC metadata from the input CSV

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Existing tests extended.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@joel-wright joel-wright requested a review from diversemix May 31, 2023 10:03
Copy link
Contributor

@diversemix diversemix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ... we could add another test to navigator-backend/tests/core/ingestion/test_unfccc_ingest_row.py to check that the meta data of author has been added during ingest too for completeness?

@joel-wright joel-wright merged commit 250de29 into main May 31, 2023
@joel-wright joel-wright deleted the fix/author-in-metadata branch May 31, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants