Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOF-40 Add document_url for the pipeline #115

Merged
merged 2 commits into from
May 22, 2023
Merged

SOF-40 Add document_url for the pipeline #115

merged 2 commits into from
May 22, 2023

Conversation

diversemix
Copy link
Contributor

@diversemix diversemix commented May 22, 2023 •
edited
Loading

Description

Adds download_url into the file of documents for the pipeline

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@linear
Copy link

linear bot commented May 22, 2023

SOF-40 Ingest UNFCCC Docs from new CSV File

joel-wright
joel-wright reviewed May 22, 2023
View reviewed changes
Copy link

@joel-wright joel-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like I imagined :)

@diversemix diversemix marked this pull request as ready for review May 22, 2023 10:24
@diversemix diversemix added this pull request to the merge queue May 22, 2023
Merged via the queue into main with commit da19cf5 May 22, 2023
@diversemix diversemix deleted the SOF-40/add-ingest-download-url branch May 22, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joel-wright joel-wright joel-wright approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diversemix @joel-wright