Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOF-8 First re-factor to accomodate UNFCCC #113

Merged
merged 33 commits into from
May 19, 2023
Merged

Conversation

diversemix
Copy link
Contributor

@diversemix diversemix commented May 16, 2023

Description

  • Refactor to split out different types of validate and ingest for CCLW/UNFCCC

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Reviewer Checklist

  • The PR represents a single feature (small driveby fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@linear
Copy link

linear bot commented May 16, 2023

SOF-8 New ingest endpoint for GST

Similar to that for CCLW - but this will read the new input CSV schema and create the necessary data and structure in the database

Copy link

@joel-wright joel-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a decent path to go down so we learn more about writing generic ingest, the general structure seems to be shared, but there are a lot of subtle differences we'll need to handle on import for UNFCCC. e.g. separate collection creation, linking families to multiple collections during ingest, no events file (rather a single event per family).... I'm sure we could find more...

app/api/api_v1/routers/unfccc_ingest.py Outdated Show resolved Hide resolved
app/api/api_v1/routers/unfccc_ingest.py Outdated Show resolved Hide resolved
Copy link

@joel-wright joel-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing too controversial in here (although obviously, same as you, the amount of copy-pasta makes me a little sad). Unavoidable given the constraints though.... ONWARDS!!!

app/api/api_v1/routers/cclw_ingest.py Outdated Show resolved Hide resolved
app/api/api_v1/routers/cclw_ingest.py Outdated Show resolved Hide resolved
app/api/api_v1/routers/unfccc_ingest.py Outdated Show resolved Hide resolved
app/api/api_v1/routers/unfccc_ingest.py Outdated Show resolved Hide resolved
app/core/cclw_ingestion/family.py Outdated Show resolved Hide resolved
app/core/ingestion/processor.py Outdated Show resolved Hide resolved
app/core/ingestion/validator.py Show resolved Hide resolved
@diversemix diversemix marked this pull request as ready for review May 19, 2023 11:22
Copy link

@joel-wright joel-wright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get this in & fix as required

@joel-wright joel-wright added this pull request to the merge queue May 19, 2023
Merged via the queue into main with commit 99ff502 May 19, 2023
@joel-wright joel-wright deleted the SOF-8/ingest-UNF3C branch May 19, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants