-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOF-8 First re-factor to accomodate UNFCCC #113
Conversation
SOF-8 New ingest endpoint for GST
Similar to that for CCLW - but this will read the new input CSV schema and create the necessary data and structure in the database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a decent path to go down so we learn more about writing generic ingest, the general structure seems to be shared, but there are a lot of subtle differences we'll need to handle on import for UNFCCC. e.g. separate collection creation, linking families to multiple collections during ingest, no events file (rather a single event per family).... I'm sure we could find more...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing too controversial in here (although obviously, same as you, the amount of copy-pasta makes me a little sad). Unavoidable given the constraints though.... ONWARDS!!!
Co-authored-by: Joel Wright <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's get this in & fix as required
Description
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Reviewer Checklist