Fix internal server error when there are no visible languages (#163)

* Fix internal server error when there are no visible languages * Make tests match
climatepolicyradar · Aug 7, 2023 · c199d9a · c199d9a
1 parent 0525c8a
commit c199d9a
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/app/db/crud/document.py b/app/db/crud/document.py
@@ -95,7 +95,7 @@ def get_family_document_and_context(
         published_date=family.published_date,
         last_updated_date=family.last_updated_date,
     )
-    langs = _get_visible_languages_for_phys_doc(physical_document)
+    visible_languages = _get_visible_languages_for_phys_doc(physical_document)
     response = FamilyDocumentResponse(
         import_id=document.import_id,
         variant=document.variant_name,
@@ -105,8 +105,8 @@ def get_family_document_and_context(
         cdn_object=to_cdn_url(physical_document.cdn_object),
         source_url=physical_document.source_url,
         content_type=physical_document.content_type,
-        language=(langs[0] if len(langs) > 0 else ""),
-        languages=langs,
+        language=(visible_languages[0] if visible_languages else ""),
+        languages=visible_languages,
         document_type=document.document_type,
         document_role=document.document_role,
     )
@@ -233,7 +233,7 @@ def _get_documents_for_family_import_id(
     )
 
     def make_response(d: FamilyDocument) -> FamilyDocumentResponse:
-        langs = _get_visible_languages_for_phys_doc(d.physical_document)
+        visible_languages = _get_visible_languages_for_phys_doc(d.physical_document)
         return FamilyDocumentResponse(
             import_id=cast(str, d.import_id),
             variant=cast(str, d.variant_name),
@@ -244,8 +244,8 @@ def make_response(d: FamilyDocument) -> FamilyDocumentResponse:
             cdn_object=to_cdn_url(cast(str, d.physical_document.cdn_object)),
             source_url=cast(str, d.physical_document.source_url),
             content_type=cast(str, d.physical_document.content_type),
-            language=(langs[0] if d.physical_document.languages else ""),
-            languages=langs,
+            language=(visible_languages[0] if visible_languages else ""),
+            languages=visible_languages,
             document_type=cast(str, d.document_type),
             document_role=cast(str, d.document_role),
         )