Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #82

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Fix warnings #82

merged 4 commits into from
Aug 29, 2024

Conversation

olaughter
Copy link
Contributor

Description

  1. Remove obsolete 'version' from docker compose file
  2. Remove embeddings from fieldset
    Deals with the error:
    WARNING For schema '...', fieldset 'default': Tensor fields ['...']
    cannot be mixed with non-tensor fields ['...'] in the same fieldset.
    See https://docs.vespa.ai/en/reference/schema-reference.html#fieldset
    
  3. Remove obsolete type assignment for summaries
    Deals with the warning for each field:
    WARNING For schema '...', summary field '...': Specifying the type is
    deprecated, ignored and will be an error in Vespa 9. Remove the type
    specification to silence this warning.
    
    

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail (integrated soon)
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Deals with the warning for each field:
```
WARNING For schema '...', summary field '...': Specifying the type is
deprecated, ignored and will be an error in Vespa 9. Remove the type
specification to silence this warning.
```
Deals with the error:
```
WARNING For schema '...', fieldset 'default': Tensor fields ['...']
cannot be mixed with non-tensor fields ['...'] in the same fieldset.
See https://docs.vespa.ai/en/reference/schema-reference.html#fieldset
```
@olaughter olaughter requested a review from a team as a code owner August 29, 2024 13:47
@olaughter olaughter changed the title Fo fix warns Fix warnings Aug 29, 2024
@olaughter olaughter merged commit a53f7fe into main Aug 29, 2024
6 checks passed
@olaughter olaughter deleted the fo-fix-warns branch August 29, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants