Feature/pdct 859 500 docs appear in a search #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the pydantic model to use a consistent max amount of hits that can be requested in one go. Subsequent pages can still be retrieved with continuation tokens. This is intended to give a sensible upper bound to how much we are asking from vespa in a single query
Currently these only exist in the backend. Nicer to have them here.
This was adding to query times wheich isn't what we want to profile. Having the vespa adapter as a fixture is much neater anyway
olaughter
force-pushed
the
feature/pdct-859-500-docs-appear-in-a-search
branch
3 times, most recently
from
2152d11 to
cbeddaf
Compare
These where not getting caught on backend api requests, leading to undocumented 500 errors. Note that pydantic takes value errors and raises `ValidationError`
olaughter
force-pushed
the
feature/pdct-859-500-docs-appear-in-a-search
branch
from
cbeddaf to
a91320d
Compare
THOR300
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the sdk requirements to resolve the following:
Also fixes a profiling test issue where the time included the adapter instantiation time unnecessarily.
Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR,MINOR, andPATCHversions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]with no spaces in between thebrackets and the
xType of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Before submitting
section of the
CONTRIBUTINGdocs.Writing docstrings section of the
CONTRIBUTINGdocs.