Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: exact match should not stem #145

Merged
merged 5 commits into from
Nov 28, 2024

Conversation

kdutia
Copy link
Member

@kdutia kdutia commented Nov 5, 2024

Description

Exact match now doesn't perform stemming.

Added a failing test for 'biodiversity' then fixed it.

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail (integrated soon)
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@kdutia kdutia requested a review from a team as a code owner November 5, 2024 16:53
Copy link

linear bot commented Nov 5, 2024

Copy link
Contributor

@olaughter olaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for when we are ready! If we go ahead now the next step would be a nav-infra schema change before deploying this through the backend

Copy link
Contributor

@jesse-c jesse-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It's true by default, which I guess makes sense, for Vespa's primary use cases.

@kdutia kdutia requested a review from olaughter November 28, 2024 09:59
@kdutia
Copy link
Member Author

kdutia commented Nov 28, 2024

@olaughter re-requesting review as i've updated the schema in line with the prod changes, and updated exact match search to use the new exact_not_stemmed rank-profile: see commit here

@kdutia kdutia enabled auto-merge (squash) November 28, 2024 10:02
@kdutia kdutia merged commit f71b720 into main Nov 28, 2024
6 checks passed
@kdutia kdutia deleted the feature/pods-1909-exact-match-should-not-stem branch November 28, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants