Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CLI for testing search queries #105

Merged
merged 7 commits into from
Sep 19, 2024

Conversation

kdutia
Copy link
Member

@kdutia kdutia commented Sep 17, 2024

Description

Enables dynamic summaries. Unfortunately it seems like these replace text block text for now, rather than augment it. The Vespa documentation hints at how to get summaries into another field but I haven't figured it out yet.

Adds a CLI for testing search queries. Also adds a src/cpr_sdk/cli dir and an optional cli dependency group (as to not bloat deployments).

python -m src.cpr_sdk.cli.run_search_query gives you a CLI where you can type text search queries until you're bored. Note the below screenshot is with dynamic summaries which are now disabled.

image

Proposed version

Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.

  • Skip auto-tagging
  • Patch
  • Minor version
  • Major version

Visit the Semver website to understand the
difference between MAJOR, MINOR, and PATCH versions.

Notes:

  • If none of these options are selected, auto-tagging will fail (integrated soon)
  • Where multiple options are selected, the most senior option ticked will be
    used -- e.g. Major > Minor > Patch
  • If you are selecting the version in the list above using the textbox, make
    sure your selected option is marked [x] with no spaces in between the
    brackets and the x

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Please describe the tests that you added to verify your changes.

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

Copy link

linear bot commented Sep 17, 2024

@kdutia kdutia changed the title Feature/pods 1698 enable dynamic summaries on text_block add CLI for testing search queries Sep 18, 2024
@kdutia kdutia marked this pull request as ready for review September 18, 2024 14:57
@kdutia kdutia requested a review from a team as a code owner September 18, 2024 14:57
Copy link
Contributor

@jesse-c jesse-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rich and typer seem like nicer versions of other packages I'd default to, so it's nice to learn about them.

Copy link

linear bot commented Sep 19, 2024

jesse-c added a commit that referenced this pull request Sep 19, 2024
This builds on the new CLI [2], to make it easier to use.

I've also removed left-over dependencies that are no longer needed [1].

[1] #107
[2] #105
jesse-c added a commit that referenced this pull request Sep 19, 2024
This builds on the new CLI [2], to make it easier to use.

I've also removed left-over dependencies that are no longer needed [1].

[1] #107
[2] #105
@jesse-c jesse-c mentioned this pull request Sep 19, 2024
11 tasks
jesse-c added a commit that referenced this pull request Sep 19, 2024
This builds on the new CLI [2], to make it easier to use.

I've also removed left-over dependencies that are no longer needed [1]
and added the missing Pyright configuration.

[1] #107
[2] #105
jesse-c added a commit that referenced this pull request Sep 19, 2024
This builds on the new CLI [2], to make it easier to use.

I've also removed left-over dependencies that are no longer needed [1]
and added the missing Pyright configuration.

[1] #107
[2] #105
jesse-c added a commit that referenced this pull request Sep 19, 2024
This builds on the new CLI [2], to make it easier to use.

I've also removed left-over dependencies that are no longer needed [1]
and added the missing Pyright configuration.

[1] #107
[2] #105
jesse-c added a commit that referenced this pull request Sep 19, 2024
This builds on the new CLI [2], to make it easier to use.

I've also removed left-over dependencies that are no longer needed [1]
and added the missing Pyright configuration.

[1] #107
[2] #105
jesse-c added a commit that referenced this pull request Sep 19, 2024
This builds on the new CLI [2], to make it easier to use.

I've also removed left-over dependencies that are no longer needed [1].

[1] #107
[2] #105
@kdutia kdutia merged commit efe9d2f into main Sep 19, 2024
6 checks passed
@kdutia kdutia deleted the feature/pods-1698-search-enable-dynamic-summaries branch September 19, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants