-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CLI for testing search queries #105
Merged
kdutia
merged 7 commits into
main
from
feature/pods-1698-search-enable-dynamic-summaries
Sep 19, 2024
Merged
add CLI for testing search queries #105
kdutia
merged 7 commits into
main
from
feature/pods-1698-search-enable-dynamic-summaries
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdutia
changed the title
Feature/pods 1698 enable dynamic summaries on
add CLI for testing search queries
Sep 18, 2024
text_block
jesse-c
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rich
and typer
seem like nicer versions of other packages I'd default to, so it's nice to learn about them.
11 tasks
kdutia
deleted the
feature/pods-1698-search-enable-dynamic-summaries
branch
September 19, 2024 11:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enables dynamic summaries. Unfortunately it seems like these replace text block text for now, rather than augment it. The Vespa documentation hints at how to get summaries into another field but I haven't figured it out yet.Adds a CLI for testing search queries. Also adds a
src/cpr_sdk/cli
dir and an optionalcli
dependency group (as to not bloat deployments).python -m src.cpr_sdk.cli.run_search_query
gives you a CLI where you can type text search queries until you're bored. Note the below screenshot is with dynamic summaries which are now disabled.Proposed version
Please select the option below that is most relevant from the list below. This
will be used to generate the next tag version name during auto-tagging.
Visit the Semver website to understand the
difference between
MAJOR
,MINOR
, andPATCH
versions.Notes:
used -- e.g. Major > Minor > Patch
sure your selected option is marked
[x]
with no spaces in between thebrackets and the
x
Type of change
Please select the option(s) below that are most relevant:
How Has This Been Tested?
Please describe the tests that you added to verify your changes.
Before submitting
section of the
CONTRIBUTING
docs.Writing docstrings section of the
CONTRIBUTING
docs.