Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change ramda imports to wildcard style #350

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

chrispcampbell
Copy link
Contributor

Fixes #349

@ToddFincannonEI: See issue for more details. No impact on sde behavior but needed to unblock testing via vitest.

Copy link
Collaborator

@ToddFincannonEI ToddFincannonEI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the new import syntax separately and found it worked in the latest Ramda but not 0.24.1. We are using Ramda 0.27.2 and could consider bumping to 0.29.0, but that does not look necessary at the moment.

@chrispcampbell
Copy link
Contributor Author

chrispcampbell commented Sep 5, 2023

I tested the new import syntax separately and found it worked in the latest Ramda but not 0.24.1.

Correct, it would only work in 0.25 after they migrated to ESM (way back in 2017).

We are using Ramda 0.27.2 and could consider bumping to 0.29.0, but that does not look necessary at the moment.

Yep, we can save that for another day; if it ain't broke... :)

@chrispcampbell chrispcampbell merged commit f132c8d into main Sep 5, 2023
3 checks passed
@chrispcampbell chrispcampbell deleted the chris/349-ramda-imports branch September 5, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update ramda imports
2 participants