You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of the sde CLI files, such as sde-build.js, have an async handler function, which works fine when that command is called directly (e.g. sde build --spec spec.json) but other commands are implemented by chaining and can fail when a spec file is passed on the command line. The spec file is read in an async function, but some of the chaining cases do not use async/await.
For example:
sde test calls run (which is currently not marked async)
run then calls build (also not marked async)
build calls generate (which is marked async)
Long story short, we need to add async and await in a couple more places to ensure that the spec file is read fully before proceeding with each step.
The text was updated successfully, but these errors were encountered:
Some of the
sde
CLI files, such assde-build.js
, have an async handler function, which works fine when that command is called directly (e.g.sde build --spec spec.json
) but other commands are implemented by chaining and can fail when a spec file is passed on the command line. The spec file is read in an async function, but some of the chaining cases do not use async/await.For example:
sde test
callsrun
(which is currently not markedasync
)run
then callsbuild
(also not markedasync
)build
callsgenerate
(which is markedasync
)Long story short, we need to add
async
andawait
in a couple more places to ensure that the spec file is read fully before proceeding with each step.The text was updated successfully, but these errors were encountered: