Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sde test fails to build model when a spec file is provided #35

Closed
chrispcampbell opened this issue Sep 12, 2020 · 1 comment · Fixed by #190
Closed

sde test fails to build model when a spec file is provided #35

chrispcampbell opened this issue Sep 12, 2020 · 1 comment · Fixed by #190
Assignees
Labels
Milestone

Comments

@chrispcampbell
Copy link
Contributor

Some of the sde CLI files, such as sde-build.js, have an async handler function, which works fine when that command is called directly (e.g. sde build --spec spec.json) but other commands are implemented by chaining and can fail when a spec file is passed on the command line. The spec file is read in an async function, but some of the chaining cases do not use async/await.

For example:

  • sde test calls run (which is currently not marked async)
  • run then calls build (also not marked async)
  • build calls generate (which is marked async)

Long story short, we need to add async and await in a couple more places to ensure that the spec file is read fully before proceeding with each step.

@chrispcampbell
Copy link
Contributor Author

Fixed on develop in afdbb77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant