Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for computation on 3h frequency #46

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Updates for computation on 3h frequency #46

wants to merge 37 commits into from

Conversation

emsonali
Copy link
Contributor

No description provided.

emsonali and others added 30 commits March 11, 2024 13:13
@emsonali
Update _preprocessing.py
2f71ca2
@emsonali
Merge branch 'climate-service-center:main' into master
085738f
@emsonali
Update _preprocessing.py
91a9105
@emsonali
Update convert_to_frequency.json
7df4871
@emsonali
Update convert_to_frequency.json
43bc610
@emsonali
Update convert_to_frequency.json
ad155f3
@indraneelgk
Update _preprocessing.py
89afea8 
If 3hr, do nothing.
@indraneelgk
Update _preprocessing.py
63ecb6c
@indraneelgk
some typos fixed.
a0646d6
@emsonali
Update _preprocessing.py
39befc2
@indraneelgk
Update index_calculator.py
47a35e9 
print statements.
@emsonali
Update _preprocessing.py
91afaaf
@indraneelgk
disable anything related to time frequency in preprocessing
9d0abb2
@emsonali
Update _preprocessing.py
bd55c09
@indraneelgk
preprocessing with time-related things.
0a54e78
@indraneelgk
Update _preprocessing.py
db4a9ee
@indraneelgk
remove time bounds stuff from processing.
d9cfa58
@indraneelgk
postprocessing split False
e595325
@indraneelgk
postprocessing split False
89a9410
@indraneelgk
Merge branch 'master' of https://github.com/emsonali/index_calculator
74f17c1
@indraneelgk
Revert "Merge branch 'master' of https://github.com/emsonali/index_ca…
d60dd87 
…lculator"

This reverts commit 74f17c1, reversing
changes made to 89a9410.
@indraneelgk
Revert "postprocessing split False"
c2bd461 
This reverts commit 89a9410.
@indraneelgk
Revert "postprocessing split False"
abdca40 
This reverts commit e595325.
@indraneelgk
split force false
1e665ef
@indraneelgk
Keep split technique intact.
627025c
@indraneelgk
removed processing commenting.
2fe9fda
@indraneelgk
processing.py we remove the connection to frequency.
96f5e8c 
We don't know if processing is done different based on self.freq, so we are trying to run this one.
@emsonali
Update _consts.py
0f4ccd6
@emsonali
Update convert_to_frequency.json
ac9928e
@emsonali
Update _consts.py
92df557
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (6adf2b4) to head (7696167).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   94.56%   94.57%   +0.01%     
==========================================
  Files          13       13              
  Lines        1251     1254       +3     
==========================================
+ Hits         1183     1186       +3     
  Misses         68       68
Flag Coverage Δ
unittests 94.57% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludwiglierhammer ludwiglierhammer mentioned this pull request Mar 14, 2024
Open
ludwiglierhammer
ludwiglierhammer requested changes Mar 18, 2024
View reviewed changes
index_calculator/_preprocessing.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert_time_axis is set but never used again.

index_calculator/_processing.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please uncomment these lines. We want to keep adding time bounds. Is it not working with your data?

index_calculator/index_calculator.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some print statements could be useful. Maybe we should use logging instead of print and write those statements directly in the submodules _preprocessing.py, _processing.py and _preprocessing.py

index_calculator/tables/convert_to_frequency.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, do you use hourly or 3-hourly input data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludwiglierhammer ludwiglierhammer ludwiglierhammer requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emsonali @codecov-commenter @ludwiglierhammer @indraneelgk