refactor(dia.CellView)!: early evaluation of calc attributes #2459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Perform the following actions at the start of the cell view update:
calc
expressions used in the presentation attributesThis way, their evaluated value, and their true name become available for anyone dealing with them later (it's no longer needed to evaluate the
calc()
value multiple times or check for the existence of an attribute under different names).Here's the new schema of how an attribute is set on the DOM node:
The PR also organizes the attributes into files based on their purpose.
Migration guide
It's only a breaking change if you define custom attributes (undocumented yet).
Before:
Now: